Skip to content

Commit

Permalink
Fix starlette requirements (#2051)
Browse files Browse the repository at this point in the history
* tests: fix ancient starlette requirements

Newer requests dropped support for Pyrhon < 3.8 so keep an old version
for these requirements. Hopefully it'll also be useful as reminder next
time dependabot will bump a release.

* ci: run starlette-0.14 tests before merging

To avoid regressions with dependabot bumps
  • Loading branch information
xrmx authored May 22, 2024
1 parent 68c15d8 commit 5b6075f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .ci/.matrix_framework.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ FRAMEWORK:
- aiopg-newest
- asyncpg-newest
- tornado-newest
# this has a dependency on requests, run it to catch update issues before merging. Drop after baseline > 0.21.0
- starlette-0.14
- starlette-newest
- pymemcache-newest
- graphene-2
Expand Down
3 changes: 2 additions & 1 deletion tests/requirements/reqs-starlette-0.13.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
starlette>=0.13,<0.14
aiofiles==0.7.0
requests==2.32.0
requests==2.32.1; python_version >= '3.8'
requests==2.31.0; python_version < '3.8'
-r reqs-base.txt
3 changes: 2 additions & 1 deletion tests/requirements/reqs-starlette-0.14.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
starlette>=0.14,<0.15
requests==2.32.0
requests==2.32.1; python_version >= '3.8'
requests==2.31.0; python_version < '3.8'
aiofiles
-r reqs-base.txt

0 comments on commit 5b6075f

Please sign in to comment.