-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build and push Docker image based on Chainguard base image #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
xrmx
approved these changes
May 14, 2024
reakaleek
approved these changes
May 14, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
May 17, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
May 20, 2024
xrmx
pushed a commit
that referenced
this pull request
May 24, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Release two flavours of Docker images:
Please note that we are going to preserve the current
Dockerfile
, so that users will still be able to build their own custom images based onAlpine
: this is needed becausedocker.elastic.co/wolfi/chainguard-base
is not a public base image, so docker build would fail for unauthenticated users.Tests
I created a feature branch
test/docker-images-wolfi
:Then I can test the release workflow without pushing any changes in production but generating docker images with the prefix
test-
and suffix if-wolfi
See https://github.com/elastic/apm-agent-python/actions/runs/9018252392
Docker images
The ones we usually release
Wolfi docker images
docker pull docker.elastic.co/observability/apm-agent-python:test-latest-wolfi