Fix starlette requirements #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer requests dropped support for Pyrhon < 3.8 so keep an old version for these requirements. Hopefully it'll also be useful as reminder next time dependabot will bump a release.
To avoid regressions with dependabot bumps
estolfo
approved these changes
May 22, 2024
xrmx
added a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
* tests: fix ancient starlette requirements Newer requests dropped support for Pyrhon < 3.8 so keep an old version for these requirements. Hopefully it'll also be useful as reminder next time dependabot will bump a release. * ci: run starlette-0.14 tests before merging To avoid regressions with dependabot bumps
xrmx
added a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
* tests: fix ancient starlette requirements Newer requests dropped support for Pyrhon < 3.8 so keep an old version for these requirements. Hopefully it'll also be useful as reminder next time dependabot will bump a release. * ci: run starlette-0.14 tests before merging To avoid regressions with dependabot bumps
xrmx
added a commit
that referenced
this pull request
Jun 10, 2024
* tests: fix ancient starlette requirements Newer requests dropped support for Pyrhon < 3.8 so keep an old version for these requirements. Hopefully it'll also be useful as reminder next time dependabot will bump a release. * ci: run starlette-0.14 tests before merging To avoid regressions with dependabot bumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix requirements after dependabot bump. While at it run more tests before merging to avoid regressions.
Related issues