Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate collapsing ARN table in release notes #2071

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jun 25, 2024

What does this pull request do?

Automate the details block step described in https://github.com/elastic/apm-agent-python/blob/main/CONTRIBUTING.md#releasing (last step)

Edit and publish the draft Github release created by Github Actions. Substitute the generated changelog with one hand written into the body of the release and move the agent layer ARNs under a <details> block with a summary.

The manual editing of the draft is causing a malformed markdown table

image

Source: https://github.com/elastic/apm-agent-python/releases/tag/v6.22.3

Related issues

Closes #ISSUE

@reakaleek reakaleek self-assigned this Jun 25, 2024
@reakaleek reakaleek requested a review from a team June 25, 2024 13:35
v1v
v1v previously approved these changes Jun 25, 2024
@reakaleek reakaleek requested a review from a team June 25, 2024 13:44
.ci/create-arn-table.sh Outdated Show resolved Hide resolved
.ci/create-arn-table.sh Outdated Show resolved Hide resolved
@xrmx
Copy link
Member

xrmx commented Jun 25, 2024

Thanks a lot!

@xrmx xrmx requested a review from v1v June 25, 2024 13:50
@reakaleek reakaleek enabled auto-merge (squash) June 25, 2024 13:55
@reakaleek reakaleek merged commit 4ba7a0b into main Jun 25, 2024
95 checks passed
@reakaleek reakaleek deleted the feature/fix-release-notes branch June 25, 2024 14:43
xrmx added a commit to xrmx/apm-agent-python that referenced this pull request Aug 19, 2024
* Automate collapsing ARN table in release notes

* Apply suggestions from code review

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
xrmx added a commit that referenced this pull request Aug 19, 2024
* Automate collapsing ARN table in release notes

* Apply suggestions from code review

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants