Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

[Design] Step errors are not reported correctly in the PR comment #501

Closed
v1v opened this issue Apr 29, 2020 · 0 comments · Fixed by #508
Closed

[Design] Step errors are not reported correctly in the PR comment #501

v1v opened this issue Apr 29, 2020 · 0 comments · Fixed by #508
Assignees
Labels
automation ci enhancement New feature or request

Comments

@v1v
Copy link
Member

v1v commented Apr 29, 2020

Description

This is regarding the enhancement of the GH PR comment, for some reason the steps.json does not contain the message for the error that caused the failure.

Use Case

PRs that are from first time contributors cannot run in the CI automatically, for instance elastic/beats#18061

image

The description is empty since the steps-errors.json contains the below details

{
  displayDescription: null,
  displayName: "Error signal",
  durationInMillis: 12,
  id: "70",
  input: null,
  result: "FAILURE",
  startTime: "2020-04-28T18:01:17.388+0000",
  state: "FINISHED",
  type: "STEP"
}

From the BO entrypoint

image

The URL_BO_ENTRYPOINT.../log contains the error message:

image

Question

Should we manipulate the steps-errors.json to look for all the steps with result: "FAILURE", and with displayDescription: null, to gather their LogStorageAction ?

@v1v v1v added automation ci enhancement New feature or request labels Apr 29, 2020
@v1v v1v self-assigned this Apr 30, 2020
@v1v v1v closed this as completed in #508 May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation ci enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant