Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

ci: add error message if Error signal #508

Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 30, 2020

What does this PR do?

Enhance the steps details when there is an error step since the description is not populated by default.

Why is it important?

Add more details to the PR comments mesages, therefore errors such as CI required an approval or other kind of errors will be reported with the error message.

Actions

  • Add ITs

Related issues

Closes #501

Blocked by #507

Tests

image

Wiremock

jobName=error
build=1
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/steps/?limit=10000  && 
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/tests/?status=FAILED  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/log/  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}//  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/blueTestSummary/  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/changeSet/  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/artifacts/  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/tests/?limit=10000000  &&
curl http://localhost:8080/blue/rest/organizations/jenkins/pipelines/it/getBuildInfoJsonFiles/${jobName}/runs/${build}/

@v1v v1v self-assigned this Apr 30, 2020
@v1v v1v added the automation label Apr 30, 2020
@v1v v1v requested a review from a team April 30, 2020 16:41
@botelastic botelastic bot added the master label Apr 30, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Apr 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Started by user Victor Martinez]

  • Start Time: 2020-05-04T13:42:23.155+0000

  • Duration: 6 min 13 sec (373178)

  • Commit: 145dd3b

Test stats 🧪

Test Results
Failed 0
Passed 489
Skipped 9
Total 498

v1v added 4 commits May 4, 2020 13:29
…-error-signals-with-some-log-details

* upstream/master:
  test: add ITs for the getbuildinfojsonfiles script (#507)
  Vault keys (#504)
@botelastic botelastic bot added the groovy label May 4, 2020
@v1v v1v marked this pull request as ready for review May 4, 2020 12:50
@v1v v1v requested a review from a team May 4, 2020 12:50
@v1v v1v merged commit aa1d66c into elastic:master May 4, 2020
@v1v v1v added enhancement New feature or request and removed groovy master labels May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Step errors are not reported correctly in the PR comment
3 participants