[filebeat]: improve debug logging in udp/tcp inputs (#41059)

elastic · Oct 1, 2024 · ba81f58 · ba81f58
1 parent c5d376c
commit ba81f58
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/filebeat/input/tcp/input.go b/filebeat/input/tcp/input.go
@@ -109,6 +109,7 @@ func (s *server) Run(ctx input.Context, publisher stateless.Publisher) error {
 
 	server, err := tcp.New(&s.config.Config, streaming.SplitHandlerFactory(
 		inputsource.FamilyTCP, log, tcp.MetadataCallback, func(data []byte, metadata inputsource.NetworkMetadata) {
+			log.Debugw("Data received", "bytes", len(data), "remote_address", metadata.RemoteAddr.String(), "truncated", metadata.Truncated)
 			evt := beat.Event{
 				Timestamp: time.Now(),
 				Fields: mapstr.M{

diff --git a/filebeat/input/udp/input.go b/filebeat/input/udp/input.go
@@ -99,6 +99,7 @@ func (s *server) Run(ctx input.Context, publisher stateless.Publisher) error {
 	defer metrics.Close()
 
 	server := udp.New(&s.config.Config, func(data []byte, metadata inputsource.NetworkMetadata) {
+		log.Debugw("Data received", "bytes", len(data), "remote_address", metadata.RemoteAddr.String(), "truncated", metadata.Truncated)
 		evt := beat.Event{
 			Timestamp: time.Now(),
 			Meta: mapstr.M{

diff --git a/filebeat/input/unix/input.go b/filebeat/input/unix/input.go
@@ -102,6 +102,7 @@ func (s *server) Run(ctx input.Context, publisher stateless.Publisher) error {
 	defer metrics.close()
 
 	server, err := unix.New(log, &s.config.Config, func(data []byte, _ inputsource.NetworkMetadata) {
+		log.Debugw("Data received", "bytes", len(data))
 		evt := beat.Event{
 			Timestamp: time.Now(),
 			Fields: mapstr.M{

diff --git a/filebeat/inputsource/common/streaming/listener.go b/filebeat/inputsource/common/streaming/listener.go
@@ -191,10 +191,10 @@ func (l *Listener) handleConnection(conn net.Conn) {
 
 	// Track number of clients.
 	l.clientsCount.Inc()
-	log.Debugw("New client connection.", "active_clients", l.clientsCount.Load())
+	log.Debugw("New client connection", "active_clients", l.clientsCount.Load())
 	defer func() {
 		l.clientsCount.Dec()
-		log.Debugw("Client disconnected.", "active_clients", l.clientsCount.Load())
+		log.Debugw("Client disconnected", "active_clients", l.clientsCount.Load())
 	}()
 
 	handler := l.handlerFactory(*l.config)