Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httpjson first_response false positive error bug #34747

Open
ShourieG opened this issue Mar 7, 2023 · 3 comments · Fixed by #34748
Open

Fix httpjson first_response false positive error bug #34747

ShourieG opened this issue Mar 7, 2023 · 3 comments · Fixed by #34748
Assignees
@ShourieG
Labels
discuss Issue needs further discussion. Team:Security-Service Integrations Security Service Integrations Team

Comments

@ShourieG
Copy link
Contributor

ShourieG commented Mar 7, 2023 •
edited
Loading

The first_response object was meant to serve niche use cases and hence no ability to split responses or decode them. It was meant to hold only flat JSON responses. This caused issues in other integrations where the 1st response was not a flat JSON.

Pending Tasks:
Add - "saveFirstResponse" flag option to tannable.io package after the release of 8.7
@ShourieG ShourieG self-assigned this Mar 7, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2023
@ShourieG ShourieG mentioned this issue Mar 7, 2023
Merged
6 tasks
@ShourieG
Copy link
Contributor Author

Merging the changes in the Linked PR for now for resolving outstanding issues , but keeping the issue open since we need to revisit this in future and find a better solution.

@ShourieG ShourieG reopened this Mar 15, 2023
@ShourieG ShourieG added the discuss Issue needs further discussion. label Mar 15, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShourieG ShourieG

Labels
discuss Issue needs further discussion. Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
4 participants
@narph @ebeahan @elasticmachine @ShourieG