Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricbeat/perfmon] Error reported when no error is present #38140

Closed
leehinman opened this issue Feb 27, 2024 · 1 comment · Fixed by #39404
Closed

[metricbeat/perfmon] Error reported when no error is present #38140

leehinman opened this issue Feb 27, 2024 · 1 comment · Fixed by #39404
Assignees
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@leehinman
Copy link
Contributor

leehinman commented Feb 27, 2024

PR #35896 introduced a bug in metricbeat perfmon module.

At

Error: fmt.Errorf("failed on query=%v: %w", counterPath, val.Err.Error),

The previous use of errors.Wrap, would have kept this as a nil error if val.Err.Error was nil, the current code makes a non nil Error.

This leads to things like the following in events:

"error.message": [
      "failed on query=\\\\SERVER01\\Processor(5)\\% DPC Time: %!w(<nil>)"
    ],
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 27, 2024
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 27, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants