[metricbeat] [meraki] Ignore 400 error for unsupported per-device licensing #42397
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
gpop63
added
the
Team:Obs-InfraObs
botelastic
bot
removed
the
needs_team
gpop63
added
needs_team
botelastic
bot
removed
the
needs_team
|
|
mergify
bot
added
the
backport-8.x
gpop63
changed the title
getDeviceLicenses func
| @@ -150,6 +150,10 @@ func getDeviceChannelUtilization(client *meraki.Client, devices map[Serial]*Devi | |||
| func getDeviceLicenses(client *meraki.Client, organizationID string, devices map[Serial]*Device) error { | |||
| val, res, err := client.Organizations.GetOrganizationLicenses(organizationID, &meraki.GetOrganizationLicensesQueryParams{}) | |||
| if err != nil { | |||
| // Ignore 400 error for per-device licensing not supported | |||
| if res.StatusCode() == 400 { | |||
There was a problem hiding this comment.
Shouldn't we check for any 4xx error and not just 400?
There was a problem hiding this comment.
Not sure if we should skip all 4xx error codes, 404 for example could mean the organization was not found meaning the org ID provided in the config is wrong.
There was a problem hiding this comment.
right. but it also can be something different. I mean I'm pretty sure that even 400 can be returned in multiple cases (something else can be invalid, might not be related to licensing not being supported, right?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We should continue collecting metrics even if the
getDeviceLicensesfunction errors with 400 status code.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
getDeviceLicensesfails for organizations that do not support per-device licensing #42395Use cases
Screenshots
Logs