Added cloudflarebeat to list of communitybeats #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
Thanks for adding the beat. I had a quick look at the beat. In general it looks good. One thing I'm curious about is how you generate the template? It seems like your fields.yml is empty but you still have fields in the template. So I assume you are not using the auto generation with |
|
Cool. Let me know in case you hit some issues with |
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Jan 4, 2017
ruflin
pushed a commit
that referenced
this pull request
Jan 5, 2017
* Added cloudflarebeat to list of communitybeats (#3242) * Minor edit * Fix Cloudflare capitalization
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Added cloudflarebeat to list of communitybeats (elastic#3242) * Minor edit * Fix Cloudflare capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this beat can now be included in the list although keep in mind it's still in beta. I'd appreciate any feedback on it.