Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nil handling, add tests to serverless implementation #36835

Merged

Conversation

fearful-symmetry
Copy link
Contributor

Proposed commit message

This fixes an issue where a nil config can cause a panic, and adds a variety of tests to make sure we don't run into this again.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent Label for the Agent team backport-v8.11.0 Automated backport with mergify labels Oct 12, 2023
@fearful-symmetry fearful-symmetry self-assigned this Oct 12, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner October 12, 2023 19:11
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 82 min 30 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@fearful-symmetry fearful-symmetry merged commit 68bcbb0 into elastic:main Oct 12, 2023
7 checks passed
mergify bot pushed a commit that referenced this pull request Oct 12, 2023
fearful-symmetry added a commit that referenced this pull request Oct 12, 2023
(cherry picked from commit 68bcbb0)

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants