Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functionbeat doc according to functionbeat deprecation planning #36871

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jlind23
Copy link
Collaborator

@jlind23 jlind23 commented Oct 17, 2023

Update functionbeat doc to clearly state that from now on this is deprecated.

@jlind23 jlind23 requested a review from nimarezainia October 17, 2023 06:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 17, 2023
@jlind23 jlind23 marked this pull request as ready for review October 17, 2023 06:57
@jlind23 jlind23 requested a review from a team as a code owner October 17, 2023 06:57
@jlind23 jlind23 requested a review from faec October 17, 2023 06:57
@jlind23 jlind23 self-assigned this Oct 17, 2023
@jlind23 jlind23 added the Team:Elastic-Agent Label for the Agent team label Oct 17, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jlind23? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 47 min 25 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kilfoyle
Copy link
Contributor

kilfoyle commented Oct 18, 2023

@jlind23 what would you think of backporting this deprecation notice into 8.10? Then, I can update the docs build to freeze the Functionbeat docs at that level, and also move them down to the "Legacy Documentation" section of the docs home page.

@jlind23 jlind23 added backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 18, 2023
@jlind23
Copy link
Collaborator Author

jlind23 commented Oct 18, 2023

@kilfoyle sure! I'll backport it to 8.11 and 8.10 though

@jlind23 jlind23 merged commit aef4d4f into main Oct 18, 2023
6 checks passed
@jlind23 jlind23 deleted the jlind23-patch-2 branch October 18, 2023 17:15
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
jlind23 added a commit that referenced this pull request Oct 18, 2023
#36871) (#36894)

(cherry picked from commit aef4d4f)

Co-authored-by: Julien Lind <julien.lind@elastic.co>
jlind23 added a commit that referenced this pull request Oct 18, 2023
#36871) (#36893)

(cherry picked from commit aef4d4f)

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants