Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auditbeat/docs/modules: remove incorrect advice in documentation #37175

Merged
merged 1 commit into from
Nov 22, 2023
Merged

auditbeat/docs/modules: remove incorrect advice in documentation #37175

merged 1 commit into from
Nov 22, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 22, 2023

Proposed commit message

The documentation incorrectly states that socket selection of multicast that cannot be satisfied will fall back to unicast. So remove this claim.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Auditbeat Team:Security-External Integrations backport-7.17 Automated backport to the 7.17 branch with mergify 8.12-candidate backport-v8.11.0 Automated backport with mergify labels Nov 22, 2023
@efd6 efd6 self-assigned this Nov 22, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 22, 2023
@efd6
auditbeat/docs/modules: remove incorrect advice in documentation
461ee76 
The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.
@efd6 efd6 changed the title auditbeat: remove incorrect advice in documentation auditbeat/docs/modules: remove incorrect advice in documentation Nov 22, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-22T06:06:30.657+0000

  • Duration: 10 min 8 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented Nov 22, 2023

run elasticsearch-ci/docs

@efd6 efd6 marked this pull request as ready for review November 22, 2023 08:58
@efd6 efd6 requested a review from a team as a code owner November 22, 2023 08:58
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 867be3b into elastic:main Nov 22, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@efd6 @mergify
auditbeat/docs/modules: remove incorrect advice in documentation (#37175
12158e3 
)

The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.

(cherry picked from commit 867be3b)
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@efd6 @mergify
auditbeat/docs/modules: remove incorrect advice in documentation (#37175
2f1f7bd 
)

The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.

(cherry picked from commit 867be3b)
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
zmoog pushed a commit that referenced this pull request Nov 28, 2023
@mergify @efd6
auditbeat/docs/modules: remove incorrect advice in documentation (#37175
05eb197 
) (#37183)

The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.

(cherry picked from commit 867be3b)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
cmacknz pushed a commit to cmacknz/beats that referenced this pull request Jan 10, 2024
@mergify @efd6
auditbeat/docs/modules: remove incorrect advice in documentation (ela…
1d3ac4d 
…stic#37175) (elastic#37182)

The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.

(cherry picked from commit 867be3b)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
auditbeat/docs/modules: remove incorrect advice in documentation (ela…
d0ff48f 
…stic#37175)

The documentation incorrectly states that socket selection of multicast
that cannot be satisfied will fall back to unicast. So remove this
claim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.12-candidate Auditbeat backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.11.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auditbeat: docs incorrectly state that socket_type will be reverted to unicast if multicast is not available
3 participants
@efd6 @elasticmachine @andrewkroh