-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix packetbeat packaging - exclude darwin/arm64 package #37963
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Expand to view the summary
Build stats
Pipeline error
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see in Jenkins the packaging pipeline for amd
uses the below platforms:
Lines 323 to 325 in e5000b6
'windows/amd64', 'darwin/amd64', 'darwin/arm64'
While for arm uses
Line 259 in e5000b6
withEnv(["HOME=${env.WORKSPACE}", 'PLATFORMS=linux/arm64','PACKAGES=docker', "BEATS_FOLDER=${beat}"]) { |
For instance, this build ran mage package snapshot packetbeat
with these platforms: +all linux/amd64 linux/arm64 windows/amd64 darwin/amd64 darwin/arm64
[2024-02-11T09:11:29.919Z] >> Building using: cmd='build/mage-linux-amd64 golangCrossBuild', env=[CC=o64-clang, CXX=o64-clang++, GOARCH=amd64, GOARM=, GOOS=darwin, PLATFORM_ID=darwin-amd64]
[2024-02-11T09:12:40.781Z] >> golangCrossBuild: Building for darwin/arm64
[2024-02-11T09:12:40.781Z] Unable to find image 'docker.elastic.co/beats-dev/golang-crossbuild:1.21.7-darwin-arm64-debian10' locally
[2024-02-11T09:12:41.283Z] 1.21.7-darwin-arm64-debian10: Pulling from beats-dev/golang-crossbuild
What's the reason it works in Jenkins but it fails in Buildkite?
I'm not sure we mean the same packaging. |
A bit more context about what package means will help with understanding how to review these PRs 🙏
I don't understand those changes and can not see any errors in any Jenkins pipeline related to the package itself. Please point out where this particular variable is used in the Jenkins pipeline I cannot find any references about In addition,
If the error is only happening in Lines 413 to 431 in 97682f1
7.17 .
|
💚 Build Succeeded
History
cc @sharbuz |
💚 Build Succeeded
History
cc @sharbuz |
💚 Build Succeeded
History
cc @sharbuz |
💚 Build Succeeded
History
cc @sharbuz |
💚 Build Succeeded
History
cc @sharbuz |
💚 Build Succeeded
History
cc @sharbuz |
What is the problem this PR solves?
Jenkins->Buildkite pipelines migration
Packetbeat packaging fix
How does this PR solve the problem?
Exclude darwin/arm64 package from the build because this platform is unsupported
Example of the error:
https://buildkite.com/elastic/beats-packetbeat/builds/1197#018d8e8a-c9cc-4f5f-8e2a-f26fc94ccc7c/421-511
Related issues
https://github.com/elastic/ingest-dev/issues/1693