Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable buildvcs within docker #38366

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Disable buildvcs within docker #38366

merged 1 commit into from
Mar 18, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Mar 18, 2024 •
edited
Loading

Proposed commit message

Added "-buildvcs=false" to GOFLAGS to avoid VCS error during packaging.
Link to discussion: elastic/golang-crossbuild#393

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added enhancement Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify labels Mar 18, 2024
@oakrizan oakrizan requested a review from a team as a code owner March 18, 2024 11:16
@oakrizan oakrizan requested review from belimawr and faec March 18, 2024 11:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2024
@oakrizan oakrizan requested review from dliappis and alexsapran March 18, 2024 11:17
@oakrizan oakrizan enabled auto-merge (squash) March 18, 2024 11:24
dliappis
dliappis approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the reasoning in elastic/golang-crossbuild#393 e.g. this comment

@oakrizan oakrizan force-pushed the set-buildvcs-flag branch from 344a04e to b8f2b0e Compare March 18, 2024 13:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 142 min 51 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the set-buildvcs-flag branch from b8f2b0e to f36ad9b Compare March 18, 2024 15:55
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @oakrizan

@jlind23 jlind23 disabled auto-merge March 18, 2024 16:09
@jlind23 jlind23 merged commit 202b490 into elastic:main Mar 18, 2024
26 of 33 checks passed
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
@oakrizan @mergify
disabled buildvcs (#38366)
6f9e340 
Force merging this to unblock buildkite migration.

(cherry picked from commit 202b490)
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
@oakrizan @mergify
disabled buildvcs (#38366)
02ee186 
Force merging this to unblock buildkite migration.

(cherry picked from commit 202b490)
This was referenced Mar 18, 2024
Merged
Merged
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @oakrizan

pierrehilbert pushed a commit that referenced this pull request Mar 19, 2024
@mergify @oakrizan
disabled buildvcs (#38366) (#38380)
984f9ad 
Force merging this to unblock buildkite migration.

(cherry picked from commit 202b490)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Mar 19, 2024
@mergify @oakrizan
disabled buildvcs (#38366) (#38379)
612cc5a 
Force merging this to unblock buildkite migration.

(cherry picked from commit 202b490)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
dliappis added a commit to dliappis/beats that referenced this pull request Apr 23, 2024
@dliappis
Test fix for BK packaging failure
06b58bf 
PR elastic#38952 surfaced a bug with elastic#38366 where
the parameters weren't enclosed in doublet quotes.

https://buildkite.com/elastic/beats-xpack-osquerybeat/builds/1973#018f06dd-19fd-40e0-ba21-960d195f178e/131-316
@dliappis dliappis mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@dliappis dliappis dliappis approved these changes

@belimawr belimawr belimawr approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@alexsapran alexsapran Awaiting requested review from alexsapran

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakrizan @elasticmachine @belimawr @dliappis @jlind23