Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #38366) Disable buildvcs within docker #38379

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2024

Proposed commit message

Added "-buildvcs=false" to GOFLAGS to avoid VCS error during packaging.
Link to discussion: elastic/golang-crossbuild#393

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #38366 done by [Mergify](https://mergify.com).

Force merging this to unblock buildkite migration.

(cherry picked from commit 202b490)
@mergify mergify bot requested a review from a team as a code owner March 18, 2024 16:10
@mergify mergify bot added the backport label Mar 18, 2024
@mergify mergify bot requested review from fearful-symmetry and faec and removed request for a team March 18, 2024 16:10
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2024
@botelastic
Copy link

botelastic bot commented Mar 18, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 99 min 37 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan
Copy link
Contributor

@dliappis, @jlind23 - go linting fails and it's not related to the PR changes. Not sure I'd be able to fix them.

@oakrizan oakrizan requested a review from dliappis March 19, 2024 08:59
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the particular change is unrelated to the linting errors, LGTM from me.

@dliappis
Copy link
Contributor

@pierrehilbert any thoughts on #38379 (comment) ?

@oakrizan oakrizan merged commit 612cc5a into 7.17 Mar 19, 2024
67 of 71 checks passed
@oakrizan oakrizan deleted the mergify/bp/7.17/pr-38366 branch March 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants