-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply single-PID adapation for metricbeat's system/process, revert update to go-systemd
#39730
Reapply single-PID adapation for metricbeat's system/process, revert update to go-systemd
#39730
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
It might be the case that the conditional build triggers don't properly account for agentbeat. |
Alright, confirmed agentbeat builds with |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
At first glance it doesn't look like CI is actually building agentbeat with these changes. I think we need to update CI to compile x-pack/agentbeat when any of the individual Beat pipelines is triggered. That is likely why this error was missed the first time. |
@cmacknz do we want to rope CI changes into this PR? |
Proposed commit message
This reverts #39714
Which in turn reverted #39620
That original PR somehow ended up containing an update to
coreos/go-systemd
That newer version of
go-systemd
contains this file: https://github.com/coreos/go-systemd/blob/v22.5.0/internal/dlopen/dlopen_example.goWhich is copied from
coreos/pkg
: https://github.com/coreos/pkg/blob/bbd7aa9bf6fb51acc905bd45a5363ebecf065f30/dlopen/dlopen_example.goWhen the original PR was merged into beats, this caused a linker error in agentbeat, as agentbeat will import both the
go-systemd
andcoreos/pkg
libraries, resulting in two definitions ofmy_strlen
from those two identical files.For now, this just reverts the update to
go-systemd
, which isn't actually needed.What I'm still not sure about is why this wasn't caught my CI. Do we not have anything in CI that packages agentbeat? Note that hitting this bug requires a few extra args during the build process:
Going to manually test this with agent/agentbeat.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.