Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the buffer cache hit ratio calculations for performance metrics #40022

Merged
merged 14 commits into from
Jul 3, 2024

Conversation

anil-elastic
Copy link
Contributor

Proposed commit message

Enhance the buffer cache hit ratio calculations by adding buffer cache hit ratio base and modifying the calculation for performance metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Below files changes used to test it:
File : mssql/docker-compose.yml

version: '2.3'
services:
  microsoft_sqlserver:
    image: mcr.microsoft.com/mssql/server:2019-latest
    user: root
    environment:
      - ACCEPT_EULA=Y
      - SA_PASSWORD=Password123
    ports:
      - "1433:1433"

file: mssql.yml

- module: mssql
  metricsets:
    - "transaction_log"
    - "performance"
  hosts: ["sqlserver://0.0.0.0:1433"]
  username: sa
  password: Password123
  period: 10s

Related issues

Use cases

Screenshots

Logs

@anil-elastic anil-elastic requested a review from a team as a code owner June 26, 2024 12:09
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @anil-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

updated with PR number
indentation fixed.
@gpop63 gpop63 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Jun 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
@anil-elastic
Copy link
Contributor Author

@elastic/obs-infraobs-integrations I am not able to replicate the error locally because when I run MODULE="mssql" mage goIntegTest I always get below error:

performance_integration_test.go:27: failed to start service 'mssql': ps: failed to get container list: failed to get list of service names: exit status 1

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
anil-elastic and others added 4 commits July 2, 2024 22:04
Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for CI to go green.

@gpop63 gpop63 merged commit b872d5e into elastic:main Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[metricbeat mssql] buffer cache hit ratio calculations for performance metrics
4 participants