-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the buffer cache hit ratio calculations for performance metrics #40022
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
updated with PR number
indentation fixed.
@elastic/obs-infraobs-integrations I am not able to replicate the error locally because when I run MODULE="mssql" mage goIntegTest I always get below error:
|
Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's wait for CI to go green.
Proposed commit message
Enhance the buffer cache hit ratio calculations by adding buffer cache hit ratio base and modifying the calculation for performance metrics.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Below files changes used to test it:
File : mssql/docker-compose.yml
file: mssql.yml
Related issues
Use cases
Screenshots
Logs