Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat]: improve debug logging in udp/tcp inputs #41059

Merged

Conversation

aleksmaus
Copy link
Member

Proposed commit message

Addressing the issue filebeat: improve debug logging in udp/tcp inputs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Examples of added logs:

{"log.level":"debug","@timestamp":"2024-09-30T20:41:02.152-0400","log.logger":"input.tcp","log.origin":{"function":"github.com/elastic/beats/v7/filebeat/input/tcp.(*server).Run.func1","file.name":"tcp/input.go","file.line":112},"message":"Data received","service.name":"filebeat","id":"FEAD914EAB357583","host":"localhost:32001","bytes":7,"remote_address":"127.0.0.1:52756","truncated":false,"ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2024-09-30T20:42:39.869-0400","log.logger":"input.udp","log.origin":{"function":"github.com/elastic/beats/v7/filebeat/input/udp.(*server).Run.func1","file.name":"udp/input.go","file.line":102},"message":"Data received","service.name":"filebeat","id":"5CF62520E29C9FC3","host":"localhost:32001","bytes":8,"remote_address":"127.0.0.1:52667","truncated":false,"ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2024-09-30T20:45:22.175-0400","log.logger":"input.unix","log.origin":{"function":"github.com/elastic/beats/v7/filebeat/input/unix.(*server).Run.func1","file.name":"unix/input.go","file.line":105},"message":"Data received","service.name":"filebeat","id":"A41E47DC48C253F1","path":"/Users/pooh/filebeat.sock","bytes":7,"ecs.version":"1.6.0"}

@aleksmaus aleksmaus added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Oct 1, 2024
@aleksmaus aleksmaus requested review from efd6 and a team October 1, 2024 00:54
@aleksmaus aleksmaus self-assigned this Oct 1, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner October 1, 2024 00:54
@aleksmaus aleksmaus requested review from mauri870 and faec October 1, 2024 00:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 1, 2024
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 1, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from belimawr and rdner and removed request for faec October 1, 2024 07:10
@aleksmaus aleksmaus merged commit ba81f58 into elastic:main Oct 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filebeat: improve debug logging in udp/tcp inputs
6 participants