Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling and add nolint comment #41256

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

belimawr
Copy link
Contributor

Proposed commit message

See title

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist
## How to test this PR locally

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 16, 2024
@belimawr belimawr self-assigned this Oct 16, 2024
@belimawr belimawr requested a review from a team as a code owner October 16, 2024 12:31
@belimawr belimawr requested review from rdner and mauri870 October 16, 2024 12:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 16, 2024
Copy link
Contributor

mergify bot commented Oct 16, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 16, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 16, 2024
Co-authored-by: Denis <denis@rdner.de>
@belimawr belimawr requested a review from rdner October 16, 2024 12:43
@belimawr belimawr enabled auto-merge (squash) October 16, 2024 13:39
@belimawr belimawr merged commit c1fc9a9 into elastic:main Oct 16, 2024
28 of 30 checks passed
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit c1fc9a9)
pierrehilbert pushed a commit that referenced this pull request Oct 16, 2024
---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit c1fc9a9)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit to belimawr/beats that referenced this pull request Oct 18, 2024
---------

Co-authored-by: Denis <denis@rdner.de>
@belimawr belimawr deleted the fix-error-handling branch December 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants