Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump kind to 0.24.0 #41309

Merged
merged 4 commits into from
Oct 24, 2024
Merged

bump kind to 0.24.0 #41309

merged 4 commits into from
Oct 24, 2024

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Oct 18, 2024 •
edited
Loading

Proposed commit message

The current version of kind we use is 0.20.0, from 2022. This PR updates it to the latest version, 0.24.0.

Initially the builds were failing on BuildKite, as explained in the linked issue. Turns out it was missing actually installing kind, this was not needed before because the version was already preloaded. I assume asdf looks into ASDF_* environment variables and installs the required software during the action setup, but this does not seem to work with kind for some reason.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Buildkite build passing: https://buildkite.com/elastic/beats-metricbeat/builds/10658#0192a091-5b10-49ac-bb1a-a0fe61cf9aa5/187-2253

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 18, 2024
@mauri870
Copy link
Member Author

/test

@mauri870 mauri870 force-pushed the debug-kind-0.24 branch 2 times, most recently from 137153a to ecf9a72 Compare October 18, 2024 15:15
@mauri870 mauri870 changed the title DO NOT MERGE: Investigating kind 0.24 failures in BuildKite bump kind to 0.24.0 Oct 21, 2024
@mauri870 mauri870 added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 21, 2024
@mauri870 mauri870 marked this pull request as ready for review October 21, 2024 11:19
@mauri870 mauri870 requested a review from a team as a code owner October 21, 2024 11:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 requested review from belimawr and rdner October 22, 2024 10:58
@rdner rdner requested a review from pazone October 22, 2024 12:27
@mauri870 mauri870 marked this pull request as draft October 22, 2024 16:00
@alexsapran
Copy link
Contributor

/test

@alexsapran
Copy link
Contributor

alexsapran commented Oct 24, 2024 •
edited
Loading

After the latest changes add both versions of Kind, old and new.
You can see on the latest build the following
Screenshot 2024-10-24 at 9 44 07 AM

(the asterisk, is which version of the 2 is currently active)

We can now merge this PR; any open PR that still needs to be updated will continue to work. After a while, we will need to remove the older version from the VM image.

@mauri870
Copy link
Member Author

/test

@mauri870 mauri870 marked this pull request as ready for review October 24, 2024 10:36
@mauri870
Copy link
Member Author

We can now merge this PR; any open PR that still needs to be updated will continue to work. After a while, we will need to remove the older version from the VM image.

Thank you so much for the help in addressing this!

@mauri870 mauri870 enabled auto-merge (squash) October 24, 2024 10:37
@mauri870 mauri870 merged commit 3366150 into elastic:main Oct 24, 2024
28 checks passed
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@mauri870 @mergify
bump kind to 0.24.0 (#41309)
9a635e7 
* update kind to 0.24.0

(cherry picked from commit 3366150)
@mergify mergify bot mentioned this pull request Oct 24, 2024
Merged
6 tasks
@pierrehilbert
Copy link
Collaborator

@mauri870 should we backport this to 8.15 and 8.16 also?

@mauri870
Copy link
Member Author

@mauri870 should we backport this to 8.15 and 8.16 also?

I don't see a reason not to. I'll open backport PRs.

@mauri870 mauri870 added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify labels Oct 24, 2024
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@mauri870 @mergify
bump kind to 0.24.0 (#41309)
ef758bd 
* update kind to 0.24.0

(cherry picked from commit 3366150)

# Conflicts:
#	.buildkite/filebeat/filebeat-pipeline.yml
#	.buildkite/metricbeat/pipeline.yml
@mergify mergify bot mentioned this pull request Oct 24, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@mauri870 @mergify
bump kind to 0.24.0 (#41309)
9a831b4 
* update kind to 0.24.0

(cherry picked from commit 3366150)
@mergify mergify bot mentioned this pull request Oct 24, 2024
Merged
6 tasks
mauri870 added a commit that referenced this pull request Oct 24, 2024
@mergify @mauri870
bump kind to 0.24.0 (#41309) (#41426)
99e3b3b 
* update kind to 0.24.0

(cherry picked from commit 3366150)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Oct 24, 2024
@mergify @mauri870
bump kind to 0.24.0 (#41309) (#41431)
dd2d4ed 
* update kind to 0.24.0

(cherry picked from commit 3366150)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Oct 24, 2024
@mergify @mauri870
[8.15](backport #41309) bump kind to 0.24.0 (#41429)
101b0e2 
* bump kind to 0.24.0 (#41309)

* update kind to 0.24.0

(cherry picked from commit 3366150)

# Conflicts:
#	.buildkite/filebeat/filebeat-pipeline.yml
#	.buildkite/metricbeat/pipeline.yml

* fix conflicts

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@pazone pazone pazone approved these changes

@alexsapran alexsapran alexsapran approved these changes

@belimawr belimawr belimawr approved these changes

@rdner rdner Awaiting requested review from rdner

Assignees

@mauri870 mauri870

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes Integration tests fails on Buildkite with kind v0.24.0
7 participants
@mauri870 @elasticmachine @alexsapran @pierrehilbert @belimawr @pazone @swiatekm