Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #42218) [filebeat][streaming] - Added more retry codes to websocket retry logic #42229

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2025

Type of change

  • Bug

Proposed commit message

Some valid websocket retry codes were missing from the initial implementation, which could lead to retries not occurring in some scenarios, hence added some more codes to retry on. There is a table below that shows what codes are currently retryable and why.

Table Of Reasons

+---------------------------------------+---------------------------------------------------------+---------+
| Close Code                            | Description                                             | Retry?  |
+---------------------------------------+---------------------------------------------------------+---------+
| 1000 - CloseNormalClosure             | Connection closed normally.(can be a false positive)    | Yes     |
| 1001 - CloseGoingAway                 | Endpoint is going away (e.g., server shutdown).         | Yes     |
| 1002 - CloseProtocolError             | Protocol error (e.g., malformed frames).                | No      |
| 1003 - CloseUnsupportedData           | Unsupported data type received.                         | No      |
| 1005 - CloseNoStatusReceived          | No status code provided (abnormal closure).             | Yes     |
| 1006 - CloseAbnormalClosure           | Abnormal connection closure (unexpected).               | Yes     |
| 1007 - CloseInvalidFramePayloadData   | Invalid payload data (e.g., bad UTF-8).                 | No      |
| 1008 - ClosePolicyViolation           | Policy violation (e.g., authentication issues).         | No      |
| 1009 - CloseMessageTooBig             | Received message exceeds allowed size.                  | Yes     |
| 1010 - CloseMandatoryExtension        | Required extensions not supported.                      | No      |
| 1011 - CloseInternalServerErr         | Server encountered an unexpected error.                 | Yes     |
| 1012 - CloseServiceRestart            | Server is restarting.                                   | Yes     |
| 1013 - CloseTryAgainLater             | Server is overloaded; try again later.                  | Yes     |
| 1015 - CloseTLSHandshake              | TLS handshake failure (e.g., certificate issues).       | Yes     |
+---------------------------------------+---------------------------------------------------------+---------+

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42218 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jan 7, 2025
@mergify mergify bot requested a review from a team as a code owner January 7, 2025 07:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2025
@botelastic
Copy link

botelastic bot commented Jan 7, 2025

This pull request doesn't have a Team:<team> label.

@ShourieG ShourieG merged commit ea6c30f into 8.17 Jan 7, 2025
20 of 22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.17/pr-42218 branch January 7, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant