Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add investigation guide checks #2994

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mikaayenson
Copy link
Contributor

Issues

Resolves https://github.com/elastic/ia-trade-team/issues/146

Summary

This PR adds a unit-test to check all rules with guides align with the right format Investigating <Rule Name. It also adds a new workflow that checks rules in a PR for investigation guides. This check can be skipped with the skip-guide label added to the PR.

@Mikaayenson Mikaayenson added enhancement New feature or request cli command line tooling ci/cd Area: DED labels Aug 2, 2023
@Mikaayenson Mikaayenson self-assigned this Aug 2, 2023
@botelastic botelastic bot added Domain: Cloud Domain: Endpoint Integration: Google Workspace ML machine learning related rule OS: Linux OS: Windows windows related rules python Internal python for the repository labels Aug 2, 2023
Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual review LGTM 👍

paths:
- 'rules/**/*.toml'

jobs:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a step to skip if specific labels are present

@botelastic
Copy link

botelastic bot commented Oct 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale 60 days of inactivity label Oct 23, 2023
@w0rk3r w0rk3r added the backlog label Oct 24, 2023
@botelastic botelastic bot removed the stale 60 days of inactivity label Oct 24, 2023
@Mikaayenson Mikaayenson marked this pull request as draft July 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog backport: auto ci/cd cli command line tooling Domain: Cloud Domain: Endpoint enhancement New feature or request Integration: Google Workspace ML machine learning related rule OS: Linux OS: Windows windows related rules python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants