Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ATT&CK coverage URL(s) in docs/ATT&CK-coverage.md #4265

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2024

Update ATT&CK coverage URL(s) in docs/ATT&CK-coverage.md

  • Autogenerated from job attack-coverage-update: pr.

@shashank-elastic shashank-elastic added patch enhancement New feature or request labels Nov 8, 2024
@protectionsmachine
Copy link
Collaborator

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the enhancement does not break existing functionality.
  • Review the enhancement with a peer or team member for additional insights.
  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.
  • Confirm that the proper version label is applied to the PR patch, minor, major.

Copy link
Contributor

@shashank-elastic shashank-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch version double bump is to facilitate sequence of merge and avoid conflicts
from #4263

Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Manual review, looks good to me! 👍

Expecting this to merge after #4263

@shashank-elastic
Copy link
Contributor

Waiting the first patch to merge - #4263

@shashank-elastic shashank-elastic merged commit ee10be7 into main Nov 8, 2024
12 checks passed
@shashank-elastic shashank-elastic deleted the update-attack-coverage-6eb55816b branch November 8, 2024 14:57
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants