-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
go.elastic.co/apm v1 has been deprecated for a while. Update the dependency to v2.
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
gopkg.in/src-d/go-git.v4 v4.13.1 | ||
gopkg.in/yaml.v2 v2.4.0 | ||
gotest.tools/gotestsum v1.9.0 | ||
) | ||
|
||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a surprising number of additional dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is caused by module pruning (https://go.dev/ref/mod#graph-pruning) introduced in go 1.17.
The dependencies listed here are indirect dependencies. They were always there in a sense but now they are explicitly mentioned in go.mod
because go is pruning unnecessary transitive dependencies.
This is also the reason why the go.sum
has way entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I only skimmed this and missed the // indirect
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, the large number of additional dependencies in go.mod is a bit suspicious though.
What does this PR do?
go.elastic.co/apm v1 has been deprecated for a while. Update the dependency to v2.
Why is it important?
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Author's Checklist
How to test this PR locally
Related issues