Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic-agent][new spec] - Added websocket to agent spec sheet #4242

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

Please label this PR with one of the following labels, depending on the scope of your change:

  • Configuration

What does this PR do?

Websocket is a new Filebeat input added with the PR elastic/beats#37774. This PR adds it to the Filebeat spec so it can be run by the elastic-agent.

Why is it important?

This makes that input available to be used by integrations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@ShourieG ShourieG requested a review from a team as a code owner February 12, 2024 16:16
@ShourieG ShourieG requested review from AndersonQ and pchila February 12, 2024 16:16
@ShourieG ShourieG self-assigned this Feb 12, 2024
@ShourieG ShourieG added backport-skip Team:Elastic-Agent Label for the Agent team labels Feb 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@ShourieG ShourieG added Team:Service-Integrations Label for the Service Integrations team enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@narph narph added Team:Security-Service Integrations Team:Security-Service Integrations and removed Team:Service-Integrations Label for the Service Integrations team labels Feb 12, 2024
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@cmacknz cmacknz enabled auto-merge (squash) February 12, 2024 17:26
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@cmacknz cmacknz merged commit 1b89d57 into elastic:main Feb 12, 2024
9 checks passed
@ShourieG ShourieG deleted the spec/websocket branch February 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Service Integrations Team:Security-Service Integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants