From 37c23fa177c439d5b81f6575927d7670eddb416d Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Thu, 3 Oct 2024 11:50:58 +0200 Subject: [PATCH] WriteEvent Option on ChannelOptionBase is never called It is set in several ecs-dotnet projects but its never called here. IElasticsearchEventWriter is the right mechanism to override event serialization. --- src/Elastic.Channels/ChannelOptionsBase.cs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/Elastic.Channels/ChannelOptionsBase.cs b/src/Elastic.Channels/ChannelOptionsBase.cs index bf8a749..29e446e 100644 --- a/src/Elastic.Channels/ChannelOptionsBase.cs +++ b/src/Elastic.Channels/ChannelOptionsBase.cs @@ -4,9 +4,7 @@ using System; using System.Collections.Generic; -using System.IO; using System.Threading; -using System.Threading.Tasks; using Elastic.Channels.Buffers; using Elastic.Channels.Diagnostics; @@ -32,11 +30,6 @@ public abstract class ChannelOptionsBase : IChannelCallbacks< /// Provide an external cancellation token public CancellationToken? CancellationToken { get; set; } - /// - /// Optionally provides a custom write implementation to a channel. Concrete channel implementations are not required to adhere to this config - /// - public Func? WriteEvent { get; set; } = null; - /// public Action? ExportExceptionCallback { get; set; }