Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteEvent Option on ChannelOptionBase is never called #74

Merged
merged 1 commit into from
Oct 3, 2024
Merged

WriteEvent Option on ChannelOptionBase is never called #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Elastic.Channels/ChannelOptionsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

using System;
using System.Collections.Generic;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Elastic.Channels.Buffers;
using Elastic.Channels.Diagnostics;

Expand All @@ -32,11 +30,6 @@ public abstract class ChannelOptionsBase<TEvent, TResponse> : IChannelCallbacks<
/// <summary> Provide an external cancellation token </summary>
public CancellationToken? CancellationToken { get; set; }

/// <summary>
/// Optionally provides a custom write implementation to a channel. Concrete channel implementations are not required to adhere to this config
/// </summary>
public Func<Stream, CancellationToken, TEvent, Task>? WriteEvent { get; set; } = null;

/// <inheritdoc cref="IChannelCallbacks{TEvent,TResponse}.ExportExceptionCallback"/>
public Action<Exception>? ExportExceptionCallback { get; set; }

Expand Down