-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
span stacktraces config (without aligning with upstream) #369
Merged
SylvainJuge
merged 12 commits into
elastic:main
from
SylvainJuge:span-stacktrace-upstream-config
Sep 2, 2024
Merged
span stacktraces config (without aligning with upstream) #369
SylvainJuge
merged 12 commits into
elastic:main
from
SylvainJuge:span-stacktrace-upstream-config
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently blocked on having the open-telemetry/opentelemetry-java-contrib#1414 reviewed and merged, as until it's merged the config option naming is not set in stone. |
SylvainJuge
changed the title
align config with upstream contrib
span stacktraces align config with upstream contrib
Aug 22, 2024
and docs/configure.md |
…-stacktrace-upstream-config
SylvainJuge
changed the title
span stacktraces align config with upstream contrib
span stacktraces config (without aligning with upstream)
Sep 2, 2024
jackshirazi
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to open-telemetry/opentelemetry-java-contrib#1414 in the upstream contrib repo, constant is duplicated and needs to be kept in sync until available in a new contrib release.
Update: using
elastic.otel.java.span-stacktrace.min.duration
as the upstream config is not yet stable and will require further discussion, so let's stick to elastic namespace for now.