Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring default for IsBypassed inline with actual implementation #88

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jul 10, 2023

This brings our IWebProxy implementation inline with the one shipped in netfx/standard/.

/// <summary>Gets or sets a value that indicates whether to bypass the proxy server for local addresses.</summary>
/// <returns>
/// <see langword="true" /> to bypass the proxy server for local addresses; otherwise, <see langword="false" />. The default value is <see langword="false" />.</returns>
public bool BypassProxyOnLocal { get; set; }

@Mpdreamz Mpdreamz requested a review from flobernd July 10, 2023 16:07
Copy link
Collaborator

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mpdreamz Mpdreamz merged commit 04320b1 into main Jul 11, 2023
3 checks passed
@Mpdreamz Mpdreamz deleted the fix/webproxy-bypass branch July 11, 2023 08:18
@Mpdreamz Mpdreamz added bug Something isn't working v0.4.13 labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.4.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants