Tests: Remove test url with 0 as port #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the broken url test with latest urllib3 release. The 1.26.13 urllib3 release removes all the leading zero in port parsing so the zero port is similar to do not provide the port: https://github.com/urllib3/urllib3/releases/tag/1.26.13 Fix elastic#96
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
Right now it looks more like an urllib3 bug to me: urllib3/urllib3#2806 (comment) |
|
This was fixed in urllib3 1.26.14, released in January 2023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the broken url test with latest urllib3 release.
The 1.26.13 urllib3 release removes all the leading zero in port parsing so the zero port is similar to do not provide the port: https://github.com/urllib3/urllib3/releases/tag/1.26.13
Fix #96