Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last uses of mock #163

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove last uses of mock #163

merged 1 commit into from
May 20, 2024

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

The node tests still relied on the external mock library for mocking, whereas other tests have transitioned to unittest.mock. Since we support Python 3.7 and greater, we can remove that requirement and pull them in line too.

@s-t-e-v-e-n-k
Remove last uses of mock
20d207e 
The node tests still relied on the external mock library for mocking,
whereas other tests have transitioned to unittest.mock. Since we support
Python 3.7 and greater, we can remove that requirement and pull them in
line too.
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented May 20, 2024 •
edited
Loading

💚 CLA has been signed

@pquentin
Copy link
Member

Thanks! Can you please sign the CLA?

@s-t-e-v-e-n-k
Copy link
Contributor Author

I believe I have now -- is there a way to get the bot to recheck?

@s-t-e-v-e-n-k
Copy link
Contributor Author

Turns out there is! 🥇

@pquentin
Copy link
Member

pquentin commented May 20, 2024 •
edited
Loading

buildkite test this please oh right no Buildkite CI on this repository.

pquentin
pquentin approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@pquentin pquentin merged commit b5157dd into elastic:main May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Area: Tests Category: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-t-e-v-e-n-k @pquentin