Remove raise_for_status, because it will prevent catching 404s. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
@Thijsvandepoll we need a signed CLA before we can commit this change. |
|
I did sign it. What should I do with it? |
miguelgrinberg
approved these changes
Aug 7, 2024
|
@Thijsvandepoll That's it, thanks! We'll be releasing 8.15 in the next few days, so this change will be available soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response.raise_for_status()method raises HTTP exceptions for status codes. The Elasticsearch client relies for some functionality on HEAD requests to check whether resources exist. This is needed for (e.g.):client.indices.exists()client.get()Raising the 404 error code as an HTTP exception will fail all downstream functionality. Not raising it as an HTTP exception should make it consistent again with how the Elasticsearch client is expecting the responses again. See #174 for more details.