Add explicit Python 3.13 support #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not related to Python 3.13.
pquentin
force-pushed
the
python-3.13-support
branch
from
caa2c3f
to
78743cf
Compare
pquentin
commented
Sep 30, 2024
| @@ -182,7 +182,7 @@ async def perform_request( # type: ignore[override] | |||
| data=body_to_send, | |||
| headers=request_headers, | |||
| timeout=aiohttp_timeout, | |||
| **kwargs, | |||
| **kwargs, # type: ignore[arg-type] | |||
There was a problem hiding this comment.
This is not related to Python 3.13, but caused instead by aio-libs/aiohttp#8463. I.. just have no idea how to make mypy happy here, short of maybe adding a class?
| raise err from None | ||
| raise err from e |
There was a problem hiding this comment.
This is also unrelated, but it feels wrong to hide parts of exceptions. (And this was needed to debug chain certs code.)
miguelgrinberg
approved these changes
Oct 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit 6c27e2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162