Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synonyms and query rules APIs #2288

Closed
kderusso opened this issue Sep 8, 2023 · 3 comments · Fixed by #2299
Closed

Add synonyms and query rules APIs #2288

kderusso opened this issue Sep 8, 2023 · 3 comments · Fixed by #2299

Comments

@kderusso
Copy link
Member

kderusso commented Sep 8, 2023

Elasticsearch version (bin/elasticsearch --version): 8.10.0

elasticsearch-py version (elasticsearch.__versionstr__): 8.10.0

Description of the problem including expected versus actual behavior: The synonyms and query rules APIs have been added to the JavaScript client but still need to be added to the Python client. They should have gotten updated with 8.10 work but it looks like there may be additional work to do.

Also per #2269 there is some manual work required to add these APIs to the docs.

@JoshMock
Copy link
Member

JoshMock commented Sep 8, 2023

Looks like codegen is failing for the 8.10 branch, both in automation and when I try locally. Specifically when generating the synonyms API code. @pquentin had a possible fix in the code generator for it, but I don't think he's pushed it up yet. That might be the key to setting everything right again.

@kderusso
Copy link
Member Author

@JoshMock Is there an ETA for this fix? Thanks!

@pquentin
Copy link
Member

@pquentin had a possible fix in the code generator for it, but I don't think he's pushed it up yet. That might be the key to setting everything right again.

The one-line fix was for #2273, but I opened #2299 to fix this issue. It did require some manual adjustments, I suspect the code generation does not fully work for net-new APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants