Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search applications API to imports and generated docs #2269

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Aug 16, 2023

Apparently we have to manually add new API namespaces to client.py and the sphinx API doc for them to be fully accessible to end users.

For #2253

@JoshMock JoshMock changed the title Add search applications API to generated docs Add search applications API to imports and generated docs Aug 16, 2023
@JoshMock JoshMock marked this pull request as ready for review August 16, 2023 17:35
@JoshMock
Copy link
Member Author

I checked the clients-ci test output and verified that none of the integration test failures were related to this change.

@szabosteve
Copy link
Contributor

@pquentin @ezimuel @picandocodigo Would either of you mind taking a look at this PR and approve, please? Thank you in advance!

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

image

(We can discuss the unrelated run-black.py changes after merging.)

@JoshMock JoshMock merged commit aebebea into main Aug 21, 2023
17 checks passed
@JoshMock JoshMock deleted the search-app-docs branch August 21, 2023 15:57
@JoshMock
Copy link
Member Author

@pquentin btw the run-black.py change was just a tweak I noticed to make it more resilient by switching to a more machine-readable format. my laptop's default sensors output included some false positives in the old regex.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

The backport to 8.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.10 8.10
# Navigate to the new working tree
cd .worktrees/backport-8.10
# Create a new branch
git switch --create backport-2269-to-8.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 aebebea1e3dcde116c24f90bafab412d15e15a9a
# Push it to GitHub
git push --set-upstream origin backport-2269-to-8.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.10

Then, create a pull request where the base branch is 8.10 and the compare/head branch is backport-2269-to-8.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants