-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search applications API to imports and generated docs #2269
Conversation
I checked the clients-ci test output and verified that none of the integration test failures were related to this change. |
@pquentin @ezimuel @picandocodigo Would either of you mind taking a look at this PR and approve, please? Thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pquentin btw the run-black.py change was just a tweak I noticed to make it more resilient by switching to a more machine-readable format. my laptop's default |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.10 8.10
# Navigate to the new working tree
cd .worktrees/backport-8.10
# Create a new branch
git switch --create backport-2269-to-8.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 aebebea1e3dcde116c24f90bafab412d15e15a9a
# Push it to GitHub
git push --set-upstream origin backport-2269-to-8.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.10 Then, create a pull request where the |
Apparently we have to manually add new API namespaces to client.py and the sphinx API doc for them to be fully accessible to end users.
For #2253