Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop run-black.py #2289

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Drop run-black.py #2289

merged 1 commit into from
Sep 12, 2023

Conversation

pquentin
Copy link
Member

run-black.py wraps black and tries to make sure the laptop running black does not overheat, but black is more efficient these days (and I think even uses mypyc) and can go through the already mostly formatted code in the Elasticsearch client much faster than run-black.py allows.

@pquentin pquentin self-assigned this Sep 11, 2023
JoshMock added a commit to elastic/elasticsearch-serverless-python that referenced this pull request Sep 11, 2023
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. 👏

@pquentin pquentin changed the title Use black directly to avoid slow wrapper Drop run-black.py Sep 12, 2023
@pquentin pquentin merged commit 244518b into elastic:main Sep 12, 2023
8 checks passed
@pquentin pquentin deleted the remove-run-black branch September 12, 2023 04:37
pquentin pushed a commit to elastic/elasticsearch-serverless-python that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants