Switch from Elasticsearch YAML tests to client tests #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There were three different problems: * Elasticsearch automatically applied certain index_options that were missing * Two tests were using FakeEmbeddings instead of ConsistentFakeEmbeddings * One test used [1, ..., 1, i] with i going from 0 to 2. Making it going from 1 to 3 allowed the cosine similarity to work as expected.
miguelgrinberg
approved these changes
Nov 4, 2024
|
@pquentin yes, I would keep the version checks for a while, in case we want to run the test suite locally. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
(cherry picked from commit 596e7ca)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
(cherry picked from commit 596e7ca)
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly adapted from the Elasticsearch Serverless tests that already do this.
@miguelgrinberg This also bumps the tested version of Elasticsearch to 8.16. How do you want to handle the vector store tests? Do we keep the conditionals just in case we want to run those tests with 8.13 in the future?