[EuiComment] Fix typing to accurately reflect ...rest spread (#8089)

elastic · Oct 18, 2024 · 4b54564 · 4b54564
1 parent 86a1f4b
commit 4b54564
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/eui/changelogs/upcoming/8089.md b/packages/eui/changelogs/upcoming/8089.md
@@ -0,0 +1,3 @@
+**Bug fixes**
+
+- Fixed `EuiComment`'s typing to correctly reflect all accepted props
diff --git a/packages/eui/src/components/comment_list/comment.tsx b/packages/eui/src/components/comment_list/comment.tsx
@@ -8,7 +8,7 @@
 
 import React, { FunctionComponent } from 'react';
 import classNames from 'classnames';
-import { EuiTimelineItem } from '../timeline';
+import { EuiTimelineItem, EuiTimelineItemProps } from '../timeline';
 import { EuiCommentEvent, EuiCommentEventProps } from './comment_event';
 import {
   EuiCommentTimeline,
@@ -17,7 +17,8 @@ import {
 
 export interface EuiCommentProps
   extends EuiCommentEventProps,
-    EuiCommentTimelineProps {}
+    EuiCommentTimelineProps,
+    Omit<EuiTimelineItemProps, 'children' | 'icon' | 'iconAriaLabel'> {}
 
 export const EuiComment: FunctionComponent<EuiCommentProps> = ({
   children,