[WIP] fix(flyout): close flyout only on non-propagated escape #8140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we have
EuiIconTip
(consequently,EuiTooltip
) withinEuiFlyout
and with the tooltip open we click "Escape" key, the flyout gets closed. The reason is, the escape keydown event is propagated from the tooltip and captured by the flyout as its parent. Simpleevent.stopPropagation()
insideEuiTooltip
seemed to do the trick.(Right now) I'm testing other components that handle the "Escape" key and could be used as children within the flyout, and I'm writing Cypress tests to cover the behavior.
closes #8130
QA
Screen.Recording.2024-11-14.at.15.05.38.mov
General checklist
@default
if default values are missing) and playground toggles