Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed unreachable and incorrectly used code in _examples/bulk #887

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CaelRowley
Copy link

  • Updated / removed deprecated code
  • Fixed incorrect use of signal.Notify(done, os.Interrupt)
  • Defer closing of resources that were previously unreachable
  • Added missing packages to _examples/bulk/kafka/go.mod
  • Use more idiomatic approach to receive from ticker.C channel

Copy link

cla-checker-service bot commented Jul 6, 2024

💚 CLA has been signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant