-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Add billing additional fields #8343
Conversation
83068df
to
5c83775
Compare
🌐 Coverage report
|
Lets add the sample data here |
@gpop63 : Please do the needful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good; I only have one question and one nit.
Question
The PR on Beats introduced a detailed usage cost table alongside the existing standard table. IIRC, users must use the detailed table pattern to get the extra fields.
How do integration users get standard vs. detailed usage cost data? Should they use the detailed table pattern as well?
If users get standard vs. detailed usage cost data by setting the table pattern, we should describe this behavior in the docs and give a hint in the setting description in the UI.
Nit
We should include tag values in the sample document.
"sku_description": "Network Inter Region Ingress from Jakarta to Americas", | ||
"service_description": "Compute Engine", | ||
"effective_price": 0.00292353, | ||
"tags": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It would be helpful to include tag values in the sample event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs update!
feature is available in 8.12.0
Package gcp - 2.32.0 containing this change is available at https://epr.elastic.co/search?package=gcp |
Overview
This change introduces new billing fields and fixes the aggregation functions in the billing dashboard lenses.
Previously, the
max
aggregation was used, since the granularity of the billing data was low. Due to increased granularity which produces multiple documents per day, thesum
aggregation is appropriate for accurately displaying total costs.Fields added:
sku_id
sku_description
service_id
service_description
effective_price
tags
(nested)key
value
With these additional fields, we can add new lenses to improve the insight into billing data. This should be handled in a separate enhancement PR.
Following the merge of elastic/beats#36902, we can proceed with this PR.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots