wip

elastic · Nov 12, 2024 · 3f9a454 · 3f9a454
1 parent 16ef068
commit 3f9a454
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/dev_docs/tutorials/advanced_settings.mdx b/dev_docs/tutorials/advanced_settings.mdx
@@ -108,7 +108,6 @@ export class ChartsPlugin implements Plugin<ChartsPluginSetup, ChartsPluginStart
     };
   }
 }
-
 ```
 
 ### Server side usage

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/data.js b/src/plugins/vis_types/vislib/public/vislib/lib/data.js
@@ -45,15 +45,11 @@ class D3MappableObject {
  * @param attr {Object|*} Visualization options
  */
 export class Data {
-  constructor(data, uiState, createColorLookupFunction) {
+  constructor(data, uiState) {
     this.uiState = uiState;
-    this.createColorLookupFunction = createColorLookupFunction;
     this.data = this.copyDataObj(data);
     this.type = this.getDataType();
     this.labels = this._getLabels(this.data);
-    this.color = this.labels
-      ? createColorLookupFunction(this.labels, uiState.get('vis.colors'))
-      : undefined;
     this._normalizeOrdered();
   }
 
@@ -385,7 +381,7 @@ export class Data {
     const defaultColors = this.uiState.get('vis.defaultColors');
     const overwriteColors = this.uiState.get('vis.colors');
     const colors = defaultColors ? _.defaults({}, overwriteColors, defaultColors) : overwriteColors;
-    return this.createColorLookupFunction(this.getLabels(), colors);
+    return (value) => colors[value];
   }
 
   /**

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/vis_config.js b/src/plugins/vis_types/vislib/public/vislib/lib/vis_config.js
@@ -25,8 +25,8 @@ const DEFAULT_VIS_CONFIG = {
 };
 
 export class VisConfig {
-  constructor(visConfigArgs, data, uiState, el, createColorLookupFunction) {
-    this.data = new Data(data, uiState, createColorLookupFunction);
+  constructor(visConfigArgs, data, uiState, el) {
+    this.data = new Data(data, uiState);
 
     const visType = visTypes[visConfigArgs.type];
     const typeDefaults = visType(visConfigArgs, this.data);

diff --git a/src/plugins/vis_types/vislib/public/vislib/vis.js b/src/plugins/vis_types/vislib/public/vislib/vis.js
@@ -41,13 +41,7 @@ export class Vis extends EventEmitter {
   initVisConfig(data, uiState) {
     this.data = data;
     this.uiState = uiState;
-    this.visConfig = new VisConfig(
-      this.visConfigArgs,
-      this.data,
-      this.uiState,
-      this.element,
-      this.charts.legacyColors.createColorLookupFunction.bind(this.charts.legacyColors)
-    );
+    this.visConfig = new VisConfig(this.visConfigArgs, this.data, this.uiState, this.element);
   }
 
   /**