Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uiActions] display toast when action.execute throws #198571

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[uiActions] display toast when action.execute throws #198571

wants to merge 8 commits into from
+56 −4

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 31, 2024

Follow up to #198517.

This PR updates Ui actions to be more robust and safely handle runtime errors.

@nreese nreese requested a review from a team as a code owner October 31, 2024 15:53
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.17.0 labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the backport:version Backport to applied version labels label Oct 31, 2024
Dosant
Dosant approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nreese
Copy link
Contributor Author

nreese commented Nov 8, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActions 23.5KB 23.8KB +309.0B

History

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @Dosant @kibanamachine