Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Papercuts] Customize link sizes #199528

Closed
wants to merge 10 commits into from
Closed

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Nov 8, 2024

Summary

Partially closes #172813

This PR allows links in panels to other dashboards to have different sizes. This styling is not impacting external links.

  • size of the link <-- this PR
  • background color?
  • font color?
  • bold/italic fonts

Checklist

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 8, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@rshen91 rshen91 self-assigned this Nov 8, 2024
@rshen91 rshen91 added the papercut Small "burr" in the product that we should fix. label Nov 8, 2024
@rshen91 rshen91 added release_note:enhancement backport:skip This commit does not require backporting labels Nov 11, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #108 / links panel links panel create and edit creation can create a new by-reference links panel
  • [job] [logs] FTR Configs #108 / links panel links panel create and edit creation can create a new by-reference links panel
  • [job] [logs] Jest Tests #3 / UserActionsList renders list correctly with isExpandable option

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 52.6KB 53.4KB +893.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
links 16.8KB 17.2KB +449.0B

History

cc @rshen91

@rshen91
Copy link
Contributor Author

rshen91 commented Nov 12, 2024

Closing based on above issue that was closed as not to do

@rshen91 rshen91 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting papercut Small "burr" in the product that we should fix. release_note:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Links Panel] Configurable Font Size for Links
2 participants