Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved DELETE agent_config body to query params #200281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryce-b
Copy link
Contributor

@bryce-b bryce-b commented Nov 14, 2024

Summary

Resolved #198019. It's unclear why exactly this error was occurring to begin with, I didn't have luck with refactoring the ts-io parameters using body so I opted to move them to the query list.
I wasn't sure if the query parameters needed to be listed individually, or if I could re-use the serviceRt type.

Additionally, does the date on the API need to be updated?
Does this count as a breaking change?

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Unit or functional tests were updated or added to match the most common scenarios
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • [ x ] The PR description includes the appropriate Release Notes section, and the correct release_node:* label is applied per the guidelines

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 15, 2024

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UbsUx][APM] Delete "Agent Configuration" API failing on localhost
2 participants