[SecuritySolutuion] Fix misaligned toolbar in alerts table #196804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
added
backport
release_note:skip
1 task
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
@elasticmachine merge upstream |
jcger
approved these changes
Oct 21, 2024
|
closes #194521 thanks Jan! |
|
Starting backport for target branches: 8.16, 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…96804) ## Summary Some items in the alerts table's toolbar were misaligned. This PR adds a quick fix for these misaligned items but the actual fix will hopefully be done in EUI (elastic/eui#8085) Before: <img width="1265" alt="Screenshot 2024-10-18 at 09 47 53" src="https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf"> After: <img width="1274" alt="Screenshot 2024-10-18 at 09 47 14" src="https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a"> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 082a897)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…96804) ## Summary Some items in the alerts table's toolbar were misaligned. This PR adds a quick fix for these misaligned items but the actual fix will hopefully be done in EUI (elastic/eui#8085) Before: <img width="1265" alt="Screenshot 2024-10-18 at 09 47 53" src="https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf"> After: <img width="1274" alt="Screenshot 2024-10-18 at 09 47 14" src="https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a"> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 082a897)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…6804) (#197040) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)](#196804) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2024-10-21T11:49:39Z","message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[SecuritySolutuion] Fix misaligned toolbar in alerts table","number":196804,"url":"https://github.com/elastic/kibana/pull/196804","mergeCommit":{"message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196804","number":196804,"mergeCommit":{"message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…96804) (#197039) # Backport This will backport the following commits from `main` to `8.16`: - [[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)](#196804) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2024-10-21T11:49:39Z","message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[SecuritySolutuion] Fix misaligned toolbar in alerts table","number":196804,"url":"https://github.com/elastic/kibana/pull/196804","mergeCommit":{"message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196804","number":196804,"mergeCommit":{"message":"[SecuritySolutuion] Fix misaligned toolbar in alerts table (#196804)\n\n## Summary\r\n\r\nSome items in the alerts table's toolbar were misaligned. This PR adds a\r\nquick fix for these misaligned items but the actual fix will hopefully\r\nbe done in EUI (https://github.com/elastic/eui/pull/8085)\r\n\r\nBefore:\r\n<img width=\"1265\" alt=\"Screenshot 2024-10-18 at 09 47 53\"\r\nsrc=\"https://github.com/user-attachments/assets/b5220e8f-f26e-4847-8326-504863bc39bf\">\r\n\r\nAfter:\r\n<img width=\"1274\" alt=\"Screenshot 2024-10-18 at 09 47 14\"\r\nsrc=\"https://github.com/user-attachments/assets/ff6cbc31-301a-4b43-afc2-938262118d8a\">\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"082a89797edaa45a5d20b5378f8d521561800218"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some items in the alerts table's toolbar were misaligned. This PR adds a quick fix for these misaligned items but the actual fix will hopefully be done in EUI (elastic/eui#8085)
Before:
After:
Fixes #194521