feat(slo): improve burn rate panel #197339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
force-pushed
the
feat/burn-rate-panel-improvements
branch
from
d857b42
to
84c47d4
Compare
kdelemme
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @kdelemme |
shahzad31
approved these changes
Nov 13, 2024
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
4 tasks
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit a5b266c)
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kdelemme
added a commit
that referenced
this pull request
Nov 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [feat(slo): improve burn rate panel (#197339)](#197339) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-11-13T17:52:19Z","message":"feat(slo): improve burn rate panel (#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"number":197339,"url":"https://github.com/elastic/kibana/pull/197339","mergeCommit":{"message":"feat(slo): improve burn rate panel (#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197339","number":197339,"mergeCommit":{"message":"feat(slo): improve burn rate panel (#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #195139
🌸 Summary
The history details page was using the burn rate component but only to show the error rate chart named as "burn rate", which is incorrect. I've removed the usage of that component, and only used the ErrorRateChart on that page. I was able to refactor this component slightly to remove the need to provide a
selectedTabId.Then, I changed the burnRatePanel component to use both the short and long window burn rates in order to handle cases like recovering/increasing burn rate.
Testing
node x-pack/scripts/data_forge.js --events-per-cycle 50 --lookback now-7d --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601/kibana