Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slo): improve burn rate panel #197339

Merged
merged 19 commits into from
Nov 13, 2024
Merged

feat(slo): improve burn rate panel #197339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
666e603
return early tab component
kdelemme Oct 22, 2024
058fa9b
Remove extra divs
kdelemme Oct 22, 2024
498121d
Move alert details related components
kdelemme Oct 22, 2024
1153ff1
Move burn rate components to page folder
kdelemme Oct 22, 2024
6af0091
Reorganize layout history details
kdelemme Oct 22, 2024
f5ad7a7
Refactor history burn rates component
kdelemme Oct 22, 2024
ddae194
Inline burn rate header
kdelemme Oct 22, 2024
83fdb80
Remove div
kdelemme Oct 22, 2024
c3fcd6e
Fetch burn rate rule options from component
kdelemme Oct 22, 2024
9898259
Cleanup burn rate hook
kdelemme Oct 22, 2024
33762b9
Refactor burn rate
kdelemme Oct 22, 2024
10ea0e3
update test
kdelemme Oct 22, 2024
84c47d4
Rename component
kdelemme Oct 22, 2024
eb077ef
Update i18n
kdelemme Oct 23, 2024
ada11d2
Merge branch 'main' into feat/burn-rate-panel-improvements
kdelemme Oct 29, 2024
f1f10fb
Remove area error rate chart
kdelemme Oct 29, 2024
a5fdf77
Change line chart color based on burn rate status or SLO status when …
kdelemme Oct 31, 2024
3af3e04
Merge branch 'main' into feat/burn-rate-panel-improvements
kdelemme Nov 13, 2024
3d6ce0b
Fix merge conflict i18n
kdelemme Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ert_details/alert_details_app_section.tsx → ...ert_details/alert_details_app_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import React, { useEffect } from 'react';
import { EuiFlexGroup, EuiLink } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { AlertDetailsAppSectionProps } from '@kbn/observability-plugin/public';
import { useKibana } from '../../../../hooks/use_kibana';
import { useFetchSloDetails } from '../../../../hooks/use_fetch_slo_details';
import { useKibana } from '../../hooks/use_kibana';
import { useFetchSloDetails } from '../../hooks/use_fetch_slo_details';
import { CustomAlertDetailsPanel } from './components/custom_panels/custom_panels';
import { ErrorRatePanel } from './components/error_rate/error_rate_panel';
import { BurnRateAlert, BurnRateRule } from './types';
Expand Down
0 ...s/custom_panels/apm/apm_alert_details.tsx → ...s/custom_panels/apm/apm_alert_details.tsx
View file
Open in desktop
File renamed without changes.
0 ...nts/custom_panels/apm/embeddable_root.tsx → ...nts/custom_panels/apm/embeddable_root.tsx
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...m_panels/custom_kql/custom_kql_panels.tsx → ...m_panels/custom_kql/custom_kql_panels.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { GetSLOResponse } from '@kbn/slo-schema';
import React from 'react';
import { LogRateAnalysisPanel } from './log_rate_analysis_panel';
import { BurnRateAlert, BurnRateRule } from '../../../types';
import { useLicense } from '../../../../../../../hooks/use_license';
import { useLicense } from '../../../../../hooks/use_license';

interface Props {
slo: GetSLOResponse;
Expand Down
0 ...ts__/log_rate_analysis_query.test.ts.snap → ...ts__/log_rate_analysis_query.test.ts.snap
View file
Open in desktop
File renamed without changes.
0 ...l/helpers/log_rate_analysis_query.test.ts → ...l/helpers/log_rate_analysis_query.test.ts
View file
Open in desktop
File renamed without changes.
0 ...om_kql/helpers/log_rate_analysis_query.ts → ...om_kql/helpers/log_rate_analysis_query.ts
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...ls/custom_kql/log_rate_analysis_panel.tsx → ...ls/custom_kql/log_rate_analysis_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ import { colorTransformer } from '@kbn/observability-shared-plugin/common';
import { KQLCustomIndicator, DurationUnit } from '@kbn/slo-schema';
import { i18n } from '@kbn/i18n';
import type { Message } from '@kbn/observability-ai-assistant-plugin/public';
import type { WindowSchema } from '../../../../../../../typings';
import { TimeRange } from '../../../../../error_rate_chart/use_lens_definition';
import type { WindowSchema } from '../../../../../typings';
import { TimeRange } from '../../../../slo/error_rate_chart/use_lens_definition';
import { BurnRateAlert, BurnRateRule } from '../../../types';
import { getActionGroupFromReason } from '../../../utils/alert';
import { useKibana } from '../../../../../../../hooks/use_kibana';
import { useKibana } from '../../../../../hooks/use_kibana';
import { getESQueryForLogRateAnalysis } from './helpers/log_rate_analysis_query';
function getDataTimeRange(
timeRange: { gte: string; lte?: string },
Expand Down
0 ...omponents/custom_panels/custom_panels.tsx → ...omponents/custom_panels/custom_panels.tsx
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions ...omponents/error_rate/error_rate_panel.tsx → ...omponents/error_rate/error_rate_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ import { FormattedMessage } from '@kbn/i18n-react';
import { ALERT_EVALUATION_VALUE, ALERT_TIME_RANGE } from '@kbn/rule-data-utils';
import { GetSLOResponse } from '@kbn/slo-schema';
import React from 'react';
import { useKibana } from '../../../../../../hooks/use_kibana';
import { ErrorRateChart } from '../../../../error_rate_chart';
import { TimeRange } from '../../../../error_rate_chart/use_lens_definition';
import { useKibana } from '../../../../hooks/use_kibana';
import { ErrorRateChart } from '../../../slo/error_rate_chart';
import { TimeRange } from '../../../slo/error_rate_chart/use_lens_definition';
import { BurnRateAlert } from '../../types';
import { getActionGroupWindow } from '../../utils/alert';
import { getLastDurationInUnit } from '../../utils/last_duration_i18n';
Expand Down Expand Up @@ -153,7 +153,7 @@ export function ErrorRatePanel({ alert, slo, isLoading }: Props) {
dataTimeRange={dataTimeRange}
alertTimeRange={alertTimeRange}
threshold={actionGroupWindow!.burnRateThreshold}
showErrorRateAsLine
variant="danger"
/>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
4 changes: 2 additions & 2 deletions ...ents/slo/burn_rate/alert_details/types.ts → .../public/components/alert_details/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

import type { Rule } from '@kbn/alerting-plugin/common';
import type { TopAlert } from '@kbn/observability-plugin/public';
import type { BurnRateRuleParams } from '../../../../typings/slo';
export type { TimeRange } from '../../error_rate_chart/use_lens_definition';
import type { BurnRateRuleParams } from '../../typings/slo';
export type { TimeRange } from '../slo/error_rate_chart/use_lens_definition';

export type BurnRateRule = Rule<BurnRateRuleParams>;
export type BurnRateAlert = TopAlert;
4 changes: 2 additions & 2 deletions ...lo/burn_rate/alert_details/utils/alert.ts → ...c/components/alert_details/utils/alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import {
HIGH_PRIORITY_ACTION_ID,
LOW_PRIORITY_ACTION_ID,
MEDIUM_PRIORITY_ACTION_ID,
} from '../../../../../../common/constants';
} from '../../../../common/constants';
import { BurnRateAlert } from '../types';
import { WindowSchema } from '../../../../../typings';
import { WindowSchema } from '../../../typings';

export function getActionGroupFromReason(reason: string): string {
const prefix = reason.split(':')[0]?.toLowerCase() ?? undefined;
Expand Down
2 changes: 1 addition & 1 deletion ...alert_details/utils/last_duration_i18n.ts → ...alert_details/utils/last_duration_i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import { i18n } from '@kbn/i18n';
import moment from 'moment';
import { TimeRange } from '../../../error_rate_chart/use_lens_definition';
import { TimeRange } from '../../slo/error_rate_chart/use_lens_definition';

export function getLastDurationInUnit(timeRange: TimeRange): string {
const duration = moment.duration(moment(timeRange.to).diff(timeRange.from));
Expand Down
2 changes: 1 addition & 1 deletion ...rn_rate/alert_details/utils/time_range.ts → ...ponents/alert_details/utils/time_range.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/
import type { DateRange } from '@kbn/alerting-plugin/common';
import { ALERT_TIME_RANGE } from '@kbn/rule-data-utils';
import { TimeRange } from '../../../error_rate_chart/use_lens_definition';
import { TimeRange } from '../../slo/error_rate_chart/use_lens_definition';
import { BurnRateAlert } from '../types';
import { getActionGroupWindow } from './alert';

Expand Down
36 changes: 0 additions & 36 deletions x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.test.tsx
View file
Open in desktop

This file was deleted.

112 changes: 0 additions & 112 deletions x-pack/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate.tsx
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions ...k/plugins/observability_solution/slo/public/components/slo/burn_rate/burn_rate_header.tsx
View file
Open in desktop

This file was deleted.

Loading